Replace CircleCI with Github Actions #40
Conversation
|
Github actions aren't triggered in this pull request, because the repository doesn't have any github action defined yet. CI results can be found here: luca-rath#1 |
luca-rath
force-pushed
the
feature/github-actions
branch
from
7dc70fc to
962b977
Compare
luca-rath
force-pushed
the
feature/github-actions
branch
2 times, most recently
from
987a530 to
e4db24d
Compare
luca-rath
force-pushed
the
feature/github-actions
branch
from
e4db24d to
01e8378
Compare
|
@alexander-schranz tests are passing now |
|
@alexander-schranz can we merge this? |
| "require": { | ||
| "php": "^7.1 || ^8.0", | ||
| "twig/twig": "^1.34 || ^2.4 || ^3.0" | ||
| "twig/twig": "^1.38 || ^2.7 || ^3.0" |
There was a problem hiding this comment.
which versions we use from this versions?
There was a problem hiding this comment.
Found some Sulu 2 projects using 2.14 up to 3.3
There was a problem hiding this comment.
sorry which twig extension I meaned is required for the upgrade
There was a problem hiding this comment.
Not sure what you mean, the tests were failing for the PortalExtension and for the ComponentExtension, see https://github.com/luca-rath/web-twig/runs/3815455160?check_suite_focus=true
composer.json
Outdated
| "phpunit/phpunit": "^5.0 || ^6.0 || ^7.0 || ^7.1 || ^8.5", | ||
| "symfony/intl": "^2.8 || ^3.0 || ^4.0 || ^5.0", | ||
| "phpunit/phpunit": "^7.5 || ^8.5", | ||
| "symfony/intl": "^4.4 || ^5.0", |
There was a problem hiding this comment.
why are the old intl versions not supported?
There was a problem hiding this comment.
There was a problem hiding this comment.
We should just skip the alpha3 tests for this versions, like we skipping some tests for newer versions. e.g.:
if (!class_exists(Countries::class)) {
$this->markTestSkipped('Alpha3 requires atleast Symfony 4.4');
}
|
Just some questions about the dependency updates. |
luca-rath
force-pushed
the
feature/github-actions
branch
from
8dc3918 to
ec9a458
Compare
luca-rath
force-pushed
the
feature/github-actions
branch
from
ec9a458 to
e093b81
Compare
3 participants
No description provided.