Fix Rocm build issue #642
Merged
Fix Rocm build issue #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes ROCm cross-compilation issues by ensuring correct compile options are applied to target architectures. The fix standardizes the GPU architecture variable name and adds explicit compile options for ROCm targets.
Key changes:
- Renamed
CMAKE_HIP_ARCHITECTUREStoMSCCLPP_GPU_ARCHSfor consistency - Added
target_compile_optionswith--offload-archflags for ROCm builds in both main library and NCCL app
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| CMakeLists.txt | Updates GPU architecture variable name and adds compile options for main library |
| apps/nccl/CMakeLists.txt | Adds compile options for NCCL app ROCm builds |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Binyang2014
added a commit
that referenced
this pull request
Oct 3, 2025
Fix cross-compiling issue. Add `target_compile_options` to make sure the compile option is correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cross-compiling issue. Add
target_compile_optionsto make sure the compile option is correct