Adapt with torch 2.6 #632
Merged
Adapt with torch 2.6 #632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adapts the NCCL implementation to support PyTorch 2.6 by adding the new ncclAllToAllv function. PyTorch 2.6 requires this collective communication primitive for more flexible all-to-all operations with variable send/receive counts.
- Added
ncclAllToAllvfunction declaration and implementation - Provided comprehensive documentation for the new API
- Implemented stub functionality that returns unavailable status
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/nccl/include/mscclpp/nccl.h | Added function declarations and documentation for ncclAllToAllv and pncclAllToAllv |
| apps/nccl/src/nccl.cu | Added stub implementation of ncclAllToAllv that returns unavailable status |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
chhwang
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.