NCCL fixes #592
Merged
NCCL fixes #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses NCCL fixes including an allgather bug fix and correcting the installation path for nccl.h to go under the mscclpp/ directory. The changes also remove test code that appears to be example code borrowed from NVIDIA documentation.
- Fix allgather synchronization bug by changing from
relaxedSignal()tosignal() - Update header installation path to place files under
mscclpp/directory - Remove NCCL API test code and related CMake configuration
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| apps/nccl/test/nccl_api_test.cc | Complete removal of NCCL API test file |
| apps/nccl/test/CMakeLists.txt | Complete removal of test CMake configuration |
| apps/nccl/src/nccl.cu | Update header include path to use mscclpp/nccl.h |
| apps/nccl/src/allgather.hpp | Fix synchronization bug by changing relaxedSignal() to signal() |
| apps/nccl/CMakeLists.txt | Update header installation path and remove test subdirectory |
Binyang2014
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nccl.hinstallation path (now goes undermscclpp/)