Skip to content

Conversation

@RishabhSaini
Copy link

@RishabhSaini RishabhSaini commented Dec 12, 2025

Add pod_type support for prefill-decode (PD) disaggregated serving:

  • Added pod_type categorical feature (''=monolithic, 'prefill', 'decode') to both TTFT and TPOT prediction models
  • Implemented pod_type_cat encoding in feature preparation with proper categorical handling
  • Updated Bayesian Ridge models to one-hot encode pod_type (can't handle categoricals directly)
  • Modified XGBoost monotone constraints from 5 -> 6 features, with no constraint on pod_type
  • Added pod_type field to API models (PredictionRequest, TrainingEntry) in Python and Go
  • Ensured backward compatibility by defaulting to '' (monolithic) when pod_type is missing

Resolves: #1923

Links to related PRs:
llm-d/llm-d#442
llm-d/llm-d-inference-scheduler#511

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RishabhSaini
Once this PR has been reviewed and has the lgtm label, please assign kfswain for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Dec 12, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 7ec9c08
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/6942153f8029bb00086823ee
😎 Deploy Preview https://deploy-preview-1993--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 12, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @RishabhSaini. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 12, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 12, 2025
@kfswain kfswain added the gie-area/predictor Categorizes an issue or PR as relevant to GIE predictor label Dec 15, 2025
@kfswain kfswain requested review from kaushikmitr and removed request for kfswain and nirrozenbaum December 15, 2025 23:13
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 16, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. gie-area/predictor Categorizes an issue or PR as relevant to GIE predictor needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Predicted Latency based routing - support disagg scenarios

3 participants

SYSTEM_READY >> ...MS