SDK 2.0.0 not able to load SQL Code Analysis DLLs built with .NET 8.0

[mrlmachado]

• SqlPackage or DacFx Version: 170.2.70
• .NET Framework (Windows-only) or .NET Core: .NET 8.0
• Environment (local platform and source/target platforms): VS2022 17.14.20, .NET 8.0.4xx, Microsoft.Build.Sql 2.0.0

Steps to Reproduce:

1. Create a custom SQL Code Analysis library built with target framework .NET 8.0
2. Create a SQL Project targeting Microsoft.Build.Sql SDK 1.0.0, DacFx 162.5.57
3. Reference the custom rules dll
4. It should work fine, load the custom rules, validate the code, and all work fine.
5. Upgrade SDK version to 2.0.0, upgrade your custom rules dll to use DacFx 170.2.70
6. Try building again, using either custom rules dll, with DacFx version 162.5.57 or 170.2.70: the following error:
7. error NU1202: Package YOUR.CUSTOM.RULES.DLL 1.0.0 is not compatible with netstandard2.1 (.NE TStandard,Version=v2.1). Package YOUR.CUSTOM.RULES.DLL 1.0.0 supports: net8.0 (.NETCoreApp,Version=v8.0)

Did this occur in prior versions? If not - which version(s) did it work in?
It works fine in SDK version 1.0.0, using DacFx 162.5.57.

(DacFx/SDK/SQL Code Analysis)

[mrlmachado]

I tried to multi-target my custom rules dll, to include both .NetStandard2.1 and .NetFramework4.7.2 but DacFx 170.2.70 is not compatible with .NetStandard2.1 which makes this task impossible.

[ErikEJ]

I have rules that work fine with 170, they target net8.0 and net472

https://github.com/ErikEJ/SqlServer.Rules/blob/master/src%2FSqlServer.Rules%2FSqlServer.Rules.csproj

[mrlmachado]

I fixed it by explicitly forcing my main solution to use <TargetFramework>net8.0</TargetFramework>. It was using netstandard2.1 by default after switching to SDK 2.0.0

[mrlmachado]

It was not about the Rules dll. I guess SDK 1.0.0 uses .NET8.0 as default, that's why

[dzsquared]

Just dropping a quick note acknowledging that its super clumsy right now how we lost netstandard2.1 from DacFx (impacting code analysis rules, etc) but left Microsoft.Build.Sql as netstandard2.1.
With SqlClient returning netstandard2.1 back in SqlClient 6 we're also going to be bringing it back so there's less hoops to jump through.

thank you @ErikEJ for sharing that example, super helpful because even I get lost in how to multi-target.
@mrlmachado your fix of moving the solution to net8.0 is all good unless your SQL project has SQL CLR objects in it (SQL Server), but this is much less common and you'd know right away if it failed.

[llali]

@mrlmachado I have problems reproing the error you are seeing so adding my steps here to make sure they match yours:

1 - Created a Custom Rule in the project targeting .Net8 using DacFx 170.2.70
2 - Created a SQL Project as bellowe:

<?xml version="1.0" encoding="utf-8"?>
<Project DefaultTargets="Build">
  <Sdk Name="Microsoft.Build.Sql" Version="2.0.0" />
  <PropertyGroup>
    <Name>NetstandardTest</Name>
    <ProjectGuid>{449EE7A9-94BA-4166-8DC4-4CA83581AE0B}</ProjectGuid>
    <DSP>Microsoft.Data.Tools.Schema.Sql.Sql170DatabaseSchemaProvider</DSP>
    <ModelCollation>1033, CI</ModelCollation>
    <SqlCodeAnalysisRules>+!SqlStudio.Tests.DacExtensionSamples.CustomRuleTest.TestRule</SqlCodeAnalysisRules>
    <RunSqlCodeAnalysis>True</RunSqlCodeAnalysis>
    <SqlCodeAnalysisAssemblyPaths>.\CustomRules</SqlCodeAnalysisAssemblyPaths>
  </PropertyGroup>
  <ItemGroup>
    <None Include=".vscode\tasks.json" />
  </ItemGroup>
  <Target Name="BeforeBuild">
    <Delete Files="$(BaseIntermediateOutputPath)\project.assets.json" />
  </Target>
</Project>  

3- I put the customRule inside a folder and added to the project as you see in the example.
4- Not setting TargetFramework to anything which will be set to .NetStandard 2.1 as you mentioned
5- Ran build "dotnet build NetstandardTest.sqlproj /p:NetCoreBuild=True" I have dotnet V10 installed
I see the build error from the custom rule I added is applied

NetstandardTest netstandard2.1 failed with 1 error(s) (3.5s)
...\NetstandardTest\Table.sql(1,1,1,1): StaticCodeAnalysis error : : TestRule 170.2 for element dbo.table1

Build failed with 1 error(s) in 5.1s

[dzsquared]

@llali and I chatted - the issue repros with referencing packages, not the older style of referencing dll's directly.

[mrlmachado]

Yes @dzsquared , correct, thanks for clarifying that.

But yes, in my case, we don't have any CLR or anything that it's not supported by .NET8 and we are currently planning to upgrade to SDK 2.0.0 and .NET10 soon. So, for now all good, if I have SCA + DB targeting the same .NET version and forcing it inside the solution.

Thanks for checking this @ErikEJ and @llali